Chromium Main Console

clhager@google.com

🌱 Disable flaky testWithNoAccount_instantSignin_requiredHistorySync

Bug: 335867572
Change-Id: I71ac1423d84db2f1eab330ba1335578398ba01d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467155
Owners-Override: Charles Hager <clhager@google.com>
Commit-Queue: Charles Hager <clhager@google.com>
Reviewed-by: Aishwarya Rajesh <aishwaryarj@google.com>
Auto-Submit: Charles Hager <clhager@google.com>
Reviewed-by: Zhe Li <zheliooo@google.com>
Commit-Queue: Shu Yang <shuyng@google.com>
Reviewed-by: Shu Yang <shuyng@google.com>
Cr-Commit-Position: refs/heads/main@{#1290075}

arichiv@chromium.org

[Android OTR Session Resume] Add metrics for cookie restoration

Let's have some UMA here that will make it easy to detect issues in the
future. The failure rate should always be pretty low, so this might be
easy to set an alert on.

Bug: 335705742
Change-Id: Id211fd4e524a708af425c20cda36c90dd7aa6a05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467428
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290074}

anastasi@google.com

[ChromeVox] Move changed() to AutomationEditableText

As part of the effort to make the ChromeVox codebase more streamlined
and easier to navigate, we are moving towards removing redundant layers of abstraction such as ChromeVoxEditableTextBase. This change moves one function from that class to its only child, AutomationEditableText.

AX-Relnotes: n/a.
Bug: b:265481751
Change-Id: Ib816014f6c2714e7a0482e41a5ec1bd8c6707a1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5454044
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Auto-Submit: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290073}

luci-bisection@appspot.gserviceaccount.com

Revert "Roll src/third_party/ffmpeg/ 901248a37..af0ce8b29 (521 commits)"

This reverts commit d1ee9b4cfbdcf89a185fd1d098686f89f8d13cc7.

Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8750208296393681457

Sample failed build: https://ci.chromium.org/b/8750208296393681457

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5458841&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8750208296393681457&type=BUG

Original change's description:
> Roll src/third_party/ffmpeg/ 901248a37..af0ce8b29 (521 commits)
>
> https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/901248a373cb..af0ce8b29844
>
> $ git log 901248a37..af0ce8b29 --date=short --no-merges --format='%ad %ae %s'
> 2024-04-12 liberato README.chromium file
> 2024-04-12 liberato Chromium patches file
> 2024-04-12 liberato GN Configuration
> 2024-04-08 zhilizhao avformat/tls_mbedtls: Pass FLAG_NONBLOCK to underlying transport
> 2024-03-16 yinshiyou-hf swscale: [LA] Optimize swscale funcs in input.c
> (...)
> 2024-03-22 andreas.rheinhardt avutil/frame: Constify av_frame_side_data_get()
> 2024-03-22 andreas.rheinhardt avcodec/libx265: Pass logctx as void*, not AVClass**
> 2024-03-22 andreas.rheinhardt avcodec/libx265: Don't use AVBPrint unnecessarily
> 2024-03-22 andreas.rheinhardt fftools/ffmpeg_enc: Don't call frame_data twice
> 2024-03-22 andreas.rheinhardt avcodec/libx264: Remove unused variable
>
> Created with:
> roll-dep src/third_party/ffmpeg
>
> Bug: b/334192344
> Change-Id: I8b38126cc08e3bb86e2bc1a5357c5bb62cc1a124
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5458841
> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
> Commit-Queue: Frank Liberato <liberato@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1290022}
>

Bug: b/334192344
Change-Id: Ie582329d54f374777298e139257c6bc665428807
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5468662
Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1290072}

anastasi@google.com

[ChromeVox] Convert BrailleCaptionsBackground to TypeScript

AX-Relnotes: n/a.
Bug: b/267329383
Change-Id: Ie7c9fc8e85a39aaa88c8bb221fad98ee66be658d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5455310
Auto-Submit: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: Jacob Francis <francisjp@google.com>
Reviewed-by: Jacob Francis <francisjp@google.com>
Cr-Commit-Position: refs/heads/main@{#1290071}

bhartmire@google.com

[QuickStart]: Add QuickStart.EntryPoint histogram

Test: additions to existing browser test
Change-Id: I3d8361a1b537b06a2c646eba1bdc198c3e93f2e2
Bug: b/335482313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464143
Reviewed-by: Michael Hansen <hansenmichael@google.com>
Commit-Queue: Brittany Hartmire <bhartmire@google.com>
Reviewed-by: Renato Silva <rrsilva@google.com>
Cr-Commit-Position: refs/heads/main@{#1290070}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Chromite from 3db9d50f201a to 033823256b56 (4 revisions)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3db9d50f201a..033823256b56

2024-04-19 jrosenth@chromium.org lib: cros_sdk_lib: Implement fetching cros-sdk-latest.conf on main
2024-04-19 jrosenth@chromium.org lib: path_util: Add a tracks_main property to CheckoutInfo
2024-04-19 jrosenth@chromium.org lib: path_util: Convert CheckoutInfo to a dataclass
2024-04-19 lovisolo@google.com api: Regenerate protos

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners-reviews@google.com,chrome-os-gardeners@google.com,chromeos-velocity@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome
Tbr: chrome-os-gardeners-reviews@google.com
Change-Id: I7f16f8e396b1a12eb77e680e817a50b05059b94f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467971
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1290069}

noemies@google.com

[iOSKAUpgrade] Nicely lay out ChipButtons with a long label

In manual fill address cells, we force some ChipButtons to be displayed
on the same row. However, this doesn't adapt well when the label of
those ChipButtons are very long (see screenshots below). To fix this lay
out issue, this CL horizontally lays as many views as possible, and
starts a new row when there's not enough space left.

Before/After comparison when the KA Upgrade feature is disabled:
https://screenshot.googleplex.com/H9V8AgdfvwL28Dj.png

Before/After comparison when the KA Upgrade feature is enabled:
https://screenshot.googleplex.com/3nDBtgL9VYinCP2.png

Mocks: go/ios-keyboard-accessory-upgrade-mocks

Fixed: 330882431
Change-Id: I517f68f3e846914e8ac892d292990dda71edc41e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5454553
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Noémie St-Onge <noemies@google.com>
Cr-Commit-Position: refs/heads/main@{#1290068}

dylancutler@google.com

Render User Bypass icon when 3P cookies are blocked in A>B>A embeds

This is accomplished by adding a SiteForCookies field to
CookieAccessDetails so that
PageSpecificContentSettings::OnCookiesAccessed can tell when cookies
are blocked due to 3P cookie blocking in A>B>A embeds.

This is recorded in the blocked_third_party boolean field I am adding
to BrowsingDataModel::DataDetails.

Bug: 330218366
Change-Id: I7fa4b3d8a8991d918446a58a71131f84956bfa01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5450605
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Fiona Macintosh <fmacintosh@google.com>
Cr-Commit-Position: refs/heads/main@{#1290067}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Bundletool from XoK0RwIzanpFScg7d... to CaAT7TJbLQC0LVo1i...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/bundletool-chromium
Please CC clank-build@google.com,clank-library-failures@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Tbr: clank-library-failures@google.com
Change-Id: I5985081d71ce08496c57f6ae868921ea06a3d32d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5468307
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1290066}

agrieve@chromium.org

JNI Zero: Remove native-side null pointer check for nativeFirstParam

We recently added a Java-side assert for these, so the native-side check
is redundant.

Bug: None
Change-Id: Id93a6bc5632c79984ce806e91e4434292e91affc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5462872
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290065}

eugenex@google.com

metrics: Update structured_chromiumos.xml

Automatically generated commit, syncing recent changes to the structured.xml file in ChromiumOS to
structured_chromiumos.xml in this repository.

BUG=none
TEST=CQ

GitOrigin-RevId: 4aa1bdcb0548656e7ea11805e0cb6aec9f098fca
Change-Id: I74d4f3c298ed8b4fe3dd6cee0eb4ee8d8e9b95ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467311
Reviewed-by: Andrew Bregger <andrewbregger@google.com>
Commit-Queue: Jong Ahn <jongahn@chromium.org>
Reviewed-by: Jong Ahn <jongahn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290064}

dtapuska@chromium.org

[code health] Remove ConsolidatedMovementXY

This feature has been enabled for a while, we can remove the legacy
code path.

Bug: 41364801
Change-Id: I755b15833e2cb507d287f3b81cbedca5f8108b5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467429
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290063}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll V8 from 77b45c516e78 to 32bc32176ddf (5 revisions)

https://chromium.googlesource.com/v8/v8.git/+log/77b45c516e78..32bc32176ddf

2024-04-19 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 12.6.53
2024-04-19 leszeks@chromium.org [builtins] Use conditional moves for params size on frame leave
2024-04-19 saelo@chromium.org [sandbox] Introduce Code::parameter_count
2024-04-19 mfarazma@redhat.com [fastcall] Fix big endian platforms
2024-04-19 thibaudm@chromium.org [wasm][jspi] Introduce WA.promising and WA.Suspending

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-autoroll
Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel
Change-Id: I71c6d261389baa6da3dc482c6023a213a0f4ae39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467153
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1290062}

chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Roll optimization-guide from 07ba1bf799e2 to 2c00d9556439

https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/07ba1bf799e2..2c00d9556439

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/optimization-guide-chromium
Please CC chrome-intelligence-core@google.com,sophiechang@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Change-Id: I04c341be68216bf146509b9b63bc758302dcd87a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5468308
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1290061}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll WebRTC from d9c1b335b730 to a28350ab05d2 (1 revision)

https://webrtc.googlesource.com/src.git/+log/d9c1b335b730..a28350ab05d2

2024-04-19 terelius@webrtc.org Refactor map of RTC event log chart names

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com,webrtc-infra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I27250134d553a0452b22d9a48848746197abd7ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467535
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1290060}

andyphan@chromium.org

[OOPIF PDF] Remove feature flag check in renderer extensions code

Remove the kPdfOopif feature flag check from //extensions and
//chrome/renderer/extensions.

When the flag is disabled, GuestView PDF is enabled.

There are three existing locations that check the feature flag:
1. ResourceRequestPolicy::CanRequestResource(). This flag is safe to
remove, as GuestView PDF needs to allow the PDF extension frame and
PDF content frame to request PDF extension resources. The code
originally hidden by the flag wouldn't have been reached anyway, as
the method already returns true earlier for GuestView PDF.
2. ScriptContextSet::ClassifyJavaScriptContext(). This flag is safe to
remove, because GuestView PDF has to classify the extension as
privileged anyway, and the code hidden by the flag won't be reached
for GuestView PDF.
3. ExtensionInjectionHost::CanExecuteOnFrame(). For GuestView PDF, it
allows allowlisted extensions to run content scripts in the content
frame. Removing the flag check would disallow this. Other than that,
the code behind the flag would block all other scripts, anyway.

This will make it easier to introduce an enterprise policy for OOPIF
PDF. The delegate lives in the renderer and would've required IPC with
the browser to fetch the policy.

Bug: 324637002
Change-Id: I5bad2947f201effa4919bb50a61b7884e06345e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5448856
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290059}

katie@chromium.org

[A11y] Respect Ash overscroll pref in Lacros

Plumbs overscroll pref setting from Ash to Lacros. The pref is
set on g_browser_process so it applies to all profiles.

Bug: b:172341945
AX-Relnotes: N/A (behind flag)
Test: Manual
Change-Id: Ia482d82410409ded482594309798cd5773e1d26d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5454533
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Tzarial Kuznia <zork@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290058}

nancylanxiao@google.com

Implement UX for `BLOCKED_SCAN_FAILED`

Bug: b/327392327
Change-Id: I2f80def419cd534f802f622565a05c985f8703b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5443554
Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Nancy Xiao <nancylanxiao@google.com>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290057}

penghuang@chromium.org

graphite: block Intel GPU older than Gen 11 due to AA rendering issue

Bug: 335564846,335640712
Change-Id: Ia3c3e452d66d96c6f28fec565a810b8b6a8d07d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466263
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290056}

cduvall@chromium.org

Add language only check for on device model

This allows performing just the allowed languages check instead of the
full T&S model check.

Bug: b:335329046
Change-Id: I79b8722f85793e0fa6a686ed09fdb40fa9da7bae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466424
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290055}

gavinwill@chromium.org

Shimless: Convert repair_component_chip test to ts

- Fix all ts errors and use ts styling.

Test: browser_tests --gtest_filter=ShimlessRmaApp.RepairComponentChip
Bug: b:315002705
Change-Id: Ic7fd5d9d5bfb62ed121fe1fa45cdaffa58e821ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463286
Reviewed-by: Michael Checo <michaelcheco@google.com>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290054}

gavinwill@chromium.org

Shimless: Convert provisioning_page test to ts

- Fix all ts errors and use ts styling.

Test: browser_tests --gtest_filter=ShimlessRmaApp.ProvisioningPage
Bug: b:315002705
Change-Id: I2fd64417adb07406902fa6b457c82f287e2323d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463906
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Michael Checo <michaelcheco@google.com>
Cr-Commit-Position: refs/heads/main@{#1290053}

bsheedy@chromium.org

Suppress volteer WebGL failures

Suppresses failures on volteer devices caused by a recent WebGL roll.

Bug: 335203259, 332743717
Change-Id: I6f767468d8c01e8d324349003369ce32e2a3c1c9
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467539
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1290052}

vasilyt@chromium.org

Fix WebView invalidation when client doesn't subscribe to begin frames

WebView needs to decide if we will be drawing this frame at the
BeginFrame time, meaning that BeginFrame events needs to flow if there
is any undrawn frames. Normally this isn't an issue, because clients
actively submitting frames subscribe to them.

When client doesn't subscribe to BeginFrames, webviews need to do it
when we receive compositor frame that would damage the display.

Currently code was using
`SurfaceAggregator::previously_contained_surfaces`, which works only
after the first frame was embedded. To fix the issue, we use the same
code as Chrome that uses `damage_ranges` instead.

Bug: 335829864
Change-Id: I2678dc75f70a3c6f2535e318520ef32454762228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467023
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290051}

dibyapal@google.com

[Shortcuts] Prevent shortcuts code from building on CrOS

This CL prevents the code in chrome/browser/shortcuts/ from being
built on CrOS.

Bug: 333024272
Change-Id: Ibfec8d9085d3e182166f5ebf84b309ee58849f79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467976
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290050}

amehfooz@chromium.org

Add pixel test for AshNotificationView inline reply

Bug: b:325555641
Change-Id: I11900a782df88a0622ac9ff8027d0176292f89a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5455903
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290049}

chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Roll devtools-internal from 59d466330c14 to 637a2fe18730 (1 revision)

https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/59d466330c14..637a2fe18730

Also rolling transitive DEPS:
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/336534a922506cb048ec23931cb20efdfa646312..83ecf63b0b905fb835f38389a8130b4b19265387

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: devtools-waterfall-sheriff-onduty@rotations.google.com
Change-Id: I58cdb074f040941e82a62da11e3cf36657d64608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5468290
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1290048}

anasalazar@chromium.org

Fix apps collections segmentation fault

This CL has ShouldShowAppsCollection() verify that the client still
exists before attempting to invoke IsNewUser from it.
An AppListClient may be removed during shutdown before the
AppsCollectionsController.

Bug: 335362001
Change-Id: I5794ef4ba706fd8184cdb19806c9914e81f6c4d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464379
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290047}

wenyufu@chromium.org

[TSLO] Use app header height read from resource

Bug: 332784708
Change-Id: Ie1ad256e60059fefc8ab89dc6e6918e7fad761e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463915
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Aishwarya Rajesh <aishwaryarj@google.com>
Cr-Commit-Position: refs/heads/main@{#1290046}

lwinston@google.com

[Read Aloud] Remove return characters from PDFs strings for speech.

This prevents Read Aloud from breaking weirdly on PDFs. Since the text
we receive from PDFs has \n and \r characters to break
up each line of text, Read Aloud would interpret this as the text being
part of different sentences, instead of the same sentence split across
a line break.

To remedy this, filter out return characters from PDF strings when
calculating sentence bounds.

This has the tradeoff of some headers and lines being read together as
one segment instead of broken into multiple segments. However, the
grouped headers / lines doesn't sound as bad as sentences being
arbitrarily broken up, so I think this is an okay tradeoff.

I didn't notice any issues with the filtering on non-pdf pages, but
to be safe, I'm only applying these changes to PDFs.

Some before / after screenshots:
https://screenshot.googleplex.com/wAgVMxujgj69ke7.png

Also, after this change, extremely long "sentences" like
in https://www.un.org/sites/un2.un.org/files/2021/03/udhr.pdf
will get highlighted all at once, but though non-ideal, that
seems better than the alternative to me.

Bug: 332607621
Change-Id: Ia4486d91dc0f075fc9c9b10ecae1ec8d42e6e111
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463873
Reviewed-by: Jocelyn Tran <jocelyntran@google.com>
Commit-Queue: Lauren Winston <lwinston@google.com>
Cr-Commit-Position: refs/heads/main@{#1290045}

cbiesinger@chromium.org

[FedCM] Add a test that we cache the manifest

This is the test for https://crrev.com/c/5448079

Fixed: 332733055
Change-Id: I176bf074ca3ceefada3bd5633c2e9a12f5922c95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464070
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290044}

fmacintosh@google.com

Remove unused CookieSettingsUiAlignment feature

Change-Id: I9d362c8c99e17e2b35978a1b66aadb63d10b9f14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466058
Reviewed-by: Abe Boujane <boujane@google.com>
Auto-Submit: Fiona Macintosh <fmacintosh@google.com>
Commit-Queue: Fiona Macintosh <fmacintosh@google.com>
Commit-Queue: Abe Boujane <boujane@google.com>
Cr-Commit-Position: refs/heads/main@{#1290043}

johnchen@chromium.org

[Perf] Remove rendering.desktop.notracing from win-11-perf

Previous change https://crrev.com/1289517 missed another benchmark,
rendering.desktop.notracing, which also requires GPU and thus
can't run on current Win-11 bots.

Bug: b/295073214
Change-Id: I99139070cdfdc1ca21068459c8a26fa301abe745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467585
Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Auto-Submit: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290042}

shantuo@google.com

Differentiate zero frequency due to file not existing

We see sometimes base::SysInfo::NumberOfProcessors returns more logical
cores than the actual possible numbers on the devices. This adds a check
on the existence of /sys/devices/system/cpu/cpu* to differentiate this
case and report to a different histogram bucket.

Bug: b:324649047
Change-Id: Ibae2575fb78d12216444aab6b4e1e98381558eeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466483
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Auto-Submit: Tuo Shan <shantuo@google.com>
Reviewed-by: Nikhil Nayunigari <nikhilcn@google.com>
Commit-Queue: Tuo Shan <shantuo@google.com>
Cr-Commit-Position: refs/heads/main@{#1290041}

rasikan@google.com

[orderfile] Fix orderfile path bug

Override orderfile path correctly for 64-bit builds, which have a
non-default filename `orderfile.arm64.out`. Previously, we only
set the `chrome_orderfile_path` for "public" builds but we now need
this for internal builds as well.

Change-Id: I635e2b6c03e4f15c26dc9420c100bafdbfb34c05
Bug: 330761384
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465638
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290040}

jochen@chromium.org

[gtmooc] Some visual updates to GTMOOC page

* Link "Chrome Web Store" to the cws
* Change format of <em>
* Split last paragraph into a title and a paragraph

Bug: 40259977
Change-Id: I03bafeab6fccd4e999fb4f07feb4379ccc5e2012
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Cq-Include-Trybots: luci.chrome.try:win-chrome,linux-chrome,mac-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467721
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290039}

mek@chromium.org

Fix bug in app shim histogram registration.

AppShimHost::OnShimProcessLaunched isn't called in some edge cases where
an app shim manages to connect to chrome before chrome is informed of
the app launch having finished. As such this isn't the best place to
register with histogram code. Instead move this code to
OnBootstrapConnected, which is always called when an app shim connects
to chrome (which is the earliest point we can start getting histogram
data from it anyway).

Also make the browser test slightly more robust in making sure
histogram data from child processes is fetched before checking,
although this doesn't seem to make a difference for this test.

Bug: 335797531
Change-Id: I4474b89c0396796d6215354c00ba8165bb2ad09b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5468291
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290038}

gangwu@chromium.org

Clean up UX revamp flag in Suggestion Layout

Change-Id: I7b9a938b63307bf15905d18267d13f8fa2439b48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464136
Reviewed-by: Tomasz Wiszkowski <ender@google.com>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290037}

tangm@microsoft.com

viz: Handle color conversion for HDR content with SkCanvas::saveLayer

Instead of adding a color conversion pass during surface aggregation. Copy output requests should work fine since Skia will do a color conversion for us, albeit at the cost of an extra copy.

Bug: 41497086
Change-Id: Ife409e0b20db1f92a8fdef71fb542fd34aee4c98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5320471
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Michael Tang <tangm@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1290036}

tanzachary@chromium.org

[FedCM] Fix use other account on button flow modal

Previously, we weren't able to re-focus on the use other account pop-up
on Mac. Therefore, we landed https://crrev.com/c/5455691 as a temporary
fix before branch cut. This reverts that patch and uses a method that
can actually re-focus on Mac.

In other words, this patch
1. Enables use other account button while an existing pop-up is open.
2. Clicking on the use other account button while a pop-up is open,
resizes and focuses on the existing pop-up.
3. Closing the pop-up does not dismiss the modal, and clicking on the
use other account button again opens a new pop-up.

Bug: 335230635
Change-Id: Ib1b9ce9474fb3aadfa4ad5d6e4db63e1cf530185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463332
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Zachary Tan <tanzachary@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290035}

rainhard@chromium.org

CBD Timeframe Experiment: Dual write time-range selection prefs

To avoid in- and out-of-experiment prefs of the CBD time range
experiment (crbug.com/1487530) from diverging, the in-experiment prefs
are also written to the out-of-experiment prefs. A 15min in-experiment
selection is a 1h out-of-experiment selection. Out-of-experiment prefs
are also written to the in-experiment prefs iff the in-experiment pref
value is not TimePeriodExperiment.NOT_SELECTED.

Bug: 1487530
Change-Id: Ie561511197e0df4e220fa256129949f35ed28599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5424662
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290034}

stluong@chromium.org

Implement Performance Detection Take Action

Implements the PerformanceDetectionManager::DiscardTab() so that when
observers receive a notification that a certain health status is not
healthy but actionable, callers can take action to improve the health
status by discarding the specified pages.

Fixed: 324261604
Change-Id: I1440257da8cb6ca9c4101a20c8ba2dfe28a9481c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5415496
Commit-Queue: Steven Luong <stluong@chromium.org>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Reviewed-by: Francois Pierre Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290033}

mercerd@google.com

[lensoverlay] Add ability to adjust selected region

This CL makes the corners of a selected region draggable so user can
adjust their query. Also allows users to drag the bounding box around
the image.

Note: There is an issue with keeping the cursor in the dragging state,
but will fix in a follow up.

Demo attached to bug.

Bug: b:334958108
Change-Id: I8e2763cc87b1ae81ba534debb4d710a25b1f4094
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463888
Reviewed-by: Juan Mojica <juanmojica@google.com>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Duncan Mercer <mercerd@google.com>
Cr-Commit-Position: refs/heads/main@{#1290032}

ziadyoussef@chromium.org

Revert "Enable launcher icon for WV stable channel temporarily"

This reverts commit 03cc0660a6c56b070bc8abf98e1743e15a863771.

Reason for revert: This was a temporarily change

Original change's description:
> Enable launcher icon for WV stable channel temporarily
>
> Bug: b/260973340
> Change-Id: I26087be97faa0c369862498a018d1b08e08dc082
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5453985
> Commit-Queue: Ziad Youssef <ziadyoussef@chromium.org>
> Reviewed-by: Nate Fischer <ntfschr@chromium.org>
> Reviewed-by: Adam Walls <avvall@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1289358}

Bug: b/260973340
Change-Id: Idc460b6b08fa5f43266015bf69ac72621c8b7ef5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464308
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Adam Walls <avvall@chromium.org>
Commit-Queue: Ziad Youssef <ziadyoussef@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290031}

dcheng@chromium.org

Ban std::to_string() use

It was previously just a warning; allowlist existing violations and
upgrade this to an error to prevent it from just being ignored.

Bug: 335672557
Change-Id: I3eb7527776b0fc838abac48a41da48f0bb9e0079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464669
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290030}

chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Roll clank/internal/apps from f83d7b205630 to 2348b84db1db (1 revision)

https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/f83d7b205630..2348b84db1db

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,clhager@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: clhager@google.com
No-Try: true
Change-Id: I82c4fb201ae6ef10e63361c0f5ec694029e75509
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467536
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1290029}

smcgruer@chromium.org

Clean up expired flag 'add-identity-in-can-make-payment'

This flag expired back in M115. It was part of an opt-out origin
trial to restore certain features to the CanMakePaymentEvent IDL
file. Now that it has expired, those features can be removed entirely.

We may re-introduce a similar flag in future if/when we tackle
native app IS_READY_TO_PAY, but there is no point in keeping this
code/flag around for that potential future.

Bug: 40909272, 40212375

Change-Id: I31aa01b9406685b88de16cec5a789d21f53b2815
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5457560
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290028}

bartekn@chromium.org

[PA] Clarify comments about freelist constraints in IsWellFormed()

Change-Id: I2ef1951df02bab33128d0e383791ab0a384defcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467484
Reviewed-by: Mikihito Matsuura <mikt@google.com>
Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290027}

mka@chromium.org

histograms: Update expiration and ownership of Chrome OS dark resume metrics

Bug: b/333778418

Change-Id: I391dddf3791da7846e4620c625941f6b11a88c82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5446046
Reviewed-by: Olivier Li <olivierli@chromium.org>
Commit-Queue: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290026}