Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings page to toggle for SwiftFox #12210

Closed
data-sync-user opened this issue Oct 24, 2022 · 5 comments
Closed

Add settings page to toggle for SwiftFox #12210

data-sync-user opened this issue Oct 24, 2022 · 5 comments

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Oct 24, 2022 •
edited by lmarceau

Add a settings page with tableview

  • Add view controller for settings page in a table view format
  • Add a toggle to the settings page to Enable / Disable
  • Also, add an empty view controller to be shown if a user toggles

┆Issue is synchronized with this Jira Task
@foss-
Copy link

foss- commented Dec 12, 2022

Which release will this be part of?

@lmarceau
Copy link
Contributor

@foss- no release, this is for a secondary project not in this repository.

@foss-
Copy link

foss- commented Dec 12, 2022

Thanks, can't wait until EU clarifies situation and we can have proper Gecko Firefox on iOS.

@gutley
Copy link
Contributor

gutley commented Feb 7, 2023

Congratulations @lmarceau on your new-found fame :
https://www.theregister.com/2023/02/07/mozilla_google_apple_webkit/

@krystian3w
Copy link

krystian3w commented Jan 31, 2024 •
edited

For me, it is better to consider implementing add-ons environment (MV2/MV3) too rather than such only a small switch, which does not guarantee that they will be easily available WebExtensions with iOS 17.4 or 18 for fully Firefox.

@lmarceau lmarceau changed the title Add settings page to toggle b/w WKWebview and Gecko Add settings page to toggle for SwiftFox Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gutley @foss- @lmarceau @krystian3w @data-sync-user